chore: add version tagging and fix CI branch#39
Merged
Conversation
Maikol
force-pushed
the
mde/ci-release-tags
branch
from
f0f8032 to
369f829
Compare
Maikol
force-pushed
the
mde/ci-release-tags
branch
from
369f829 to
37ae754
Compare
Member
|
Looks good — fixes the CI branch trigger and adds proper semver tagging for releases. A few optional improvements to consider (now or in a follow-up):
None are blockers, just polish. Review by @MoonBoi9001 with @claude |
MoonBoi9001
approved these changes
Dec 16, 2025
RembrandtK
reviewed
Dec 16, 2025
| on: | ||
| push: | ||
| branches: [master] | ||
| branches: [main] |
There was a problem hiding this comment.
I would be tempted to remove explicit branches, so that it happens on all branches.
Member
Author
There was a problem hiding this comment.
I don't think we want to trigger the workflow for all commits on any branch. Current workflow runs on pull request opened and on main branch after a PR is merged, I believe this should cover all use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.